Skip to content

Adjust the project structure#1

Closed
xuzhg wants to merge 2 commits into
microsoft:tavis-mergefrom
xuzhg:AdjustStrucutre
Closed

Adjust the project structure#1
xuzhg wants to merge 2 commits into
microsoft:tavis-mergefrom
xuzhg:AdjustStrucutre

Conversation

@xuzhg

@xuzhg xuzhg commented Oct 13, 2017

Copy link
Copy Markdown
Contributor
  1. Move the test project to test folder
  2. Change the project name

The solution structure will look like:

image

  1. Change the Microsoft.OpenApi.Core.Tests.csproj target framework to 4.6.1.

1. Move the test project to test folder
2. Change the project name
@msftclas

Copy link
Copy Markdown

@xuzhg,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@darrelmiller

Copy link
Copy Markdown
Member

I'm good with the structure changes and the Microsoft prefix. I'm not a huge fan of the .core suffix. First it creates confusion with .net core and secondly it is sort of one of those generic "manager" terms that doesn't mean a whole lot. I don't feel strongly about it though. Would using Microsoft.OpenApi.Model be better? Is there a specific advantage to having the suffix?

What do you think @PerthCharern ?

@PerthCharern

Copy link
Copy Markdown
Contributor

Agree with @darrelmiller on the .Core naming. I think .Models (plural?) definitely sounds better.

On that front, does it make sense to move the Writers out to its own folder (instead of as a subfolder of the Models)? It seems more visible that way.

@xuzhg

xuzhg commented Oct 13, 2017

Copy link
Copy Markdown
Contributor Author

@darrelmiller @PerthCharern I agree that. I will change it.

@xuzhg

xuzhg commented Oct 13, 2017

Copy link
Copy Markdown
Contributor Author

@PerthCharern That's the plan to move the writer out the "model" after the structure changes.

@xuzhg xuzhg changed the title Adjust the project strucutre Adjust the project strucuture Oct 13, 2017
@darrelmiller

Copy link
Copy Markdown
Member

Sure. I'd prefer to just use Microsoft.OpenApi. I'm ok with the Writers being moved to a new folder. But the plan is it to keep it in the same project/nuget.

@xuzhg

xuzhg commented Oct 13, 2017

Copy link
Copy Markdown
Contributor Author

@darrelmiller @PerthCharern

Ok. Below is the final structure.

image

@PerthCharern

Copy link
Copy Markdown
Contributor

@darrelmiller @xuzhg Actually, ignore my comments about the writers. Not sure what I was thinking.

Agree with @darrelmiller that the Writers should be in the same project/nuget as model, so it makes sense that they are where they are right now (already in a separate folder).

The overall structure looks good to me.

@xuzhg xuzhg changed the title Adjust the project strucuture Adjust the project structure Oct 13, 2017
@xuzhg

xuzhg commented Oct 13, 2017

Copy link
Copy Markdown
Contributor Author

Merged at: 81e3b9b

@xuzhg xuzhg closed this Oct 13, 2017
@xuzhg
xuzhg deleted the AdjustStrucutre branch October 13, 2017 23:01
PerthCharern pushed a commit that referenced this pull request Nov 15, 2018
darrelmiller pushed a commit that referenced this pull request Apr 10, 2021
darrelmiller pushed a commit that referenced this pull request Apr 12, 2021
Merges origin into fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants